-
Notifications
You must be signed in to change notification settings - Fork 7.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add text on APFS in macOS High Sierra #5451
Conversation
docker-for-mac/osxfs.md
Outdated
|
||
On macOS Sierra and lower, the default file system is **HFS+**. On macOS High | ||
Sierra, the default file system is **APFS**. Both are case-insensitive by | ||
default but available in case-sensitive and case-insensitive variants. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace after "and"
docker-for-mac/osxfs.md
Outdated
|
||
To get case-sensitive behavior from your bind mounts, you must either create and | ||
format a ramdisk or external volume as HFS+ or APFS with case-sensitivity, or | ||
else you must reformat your OS root partition with HFS+ or APFS with |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't you just say, "you must format the volume used in your bind mount as HFS+ or APFS with case-sensitivity." I think ramdisk, external volume, and root partition are meant to cover everything, so we can just say "volume" no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, couple of nits.
docker-for-mac/osxfs.md
Outdated
@@ -6,23 +6,27 @@ redirect_from: | |||
title: File system sharing (osxfs) | |||
--- | |||
|
|||
`osxfs` is a new shared file system solution, exclusive to Docker for Mac. | |||
`osxfs` is a new shared file system solution, exclusive to Docker for Mac. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
whitespace
docker-for-mac/osxfs.md
Outdated
HFS+ or APFS with case-sensitivity. See the | ||
[APFS FAQ](https://developer.apple.com/library/content/documentation/FileManagement/Conceptual/APFS_Guide/FAQ/FAQ.html). | ||
|
||
We do not recommend reformatting your root partition as some Mac software relies |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe "Reformatting... is not recommended"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That was existing text but sure.
Add information on the change to APFS in macOS High Sierra.
Fixes #5318